search

jefflau / jest-fetch-mock

Jest mock for fetch
MIT License
882 stars 116 forks source link

Feature/eslint #180

Closed yinzara closed 3 years ago

yinzara commented 3 years ago

dtslint uses the now deprecated tslint library.

tslint decided to join forces with eslint and now with the @typescript-eslint/eslint-plugin and @typescript-eslint/parser, eslint can properly lint TypeScript and JavaScript files.

This PR converts jest-fetch-mock from using dtslint and no JS linter to using eslint for both.

There were changes necessary to some files to keep consistency in style across all files.

It also upgrades the library to the latest version of all dependencies.

The master build is currently broken because of issues with TypeScript and dtslint. This PR will fix them.

yinzara commented 3 years ago

@jefflau Are you ok with this change? It's kinda a major one so I wanted to make sure you were.

jefflau commented 3 years ago

@jefflau Are you ok with this change? It's kinda a major one so I wanted to make sure you were.

LGTM. Do you need me to deploy this?

yinzara commented 3 years ago

I don't think it needs a new released version. It's just a change to the linter and formatting but it means I can now fix some other issues.

jefflau commented 3 years ago

Okay cool, thanks for doing this Matthew. Appreciate you keeping things afloat whilst I'm not as active!

jefflau commented 3 years ago

Let me know if you need anything deployed

ruchernchong commented 3 years ago

I reckon the community would need this release soon.

salmaanrizvi-dd commented 2 years ago

can this be released? cross-fetch prior to 3.0.6 depends on node-fetch which has a security vulnerability @jefflau