search

jefflau / jest-fetch-mock

Jest mock for fetch
MIT License
886 stars 119 forks source link

depends on isomorphic-fetch instead of whatwg based one #31

Closed phra closed 7 years ago

phra commented 7 years ago

it's possibile to support both nodejs and browser envs if you are depending on isomorphic-fetch instead of the WHATWG based one.

phra commented 7 years ago

@jefflau any updates? otherwise i have to fork your repo with this changes and publish it separately.

jefflau commented 7 years ago

Sorry for the delay. Ive commented on your PR

phra commented 7 years ago

done. you can merge the PR. :)

phra commented 7 years ago

@jefflau you should bump the version as MINOR and ship it on npm. :shipit:

jefflau commented 7 years ago

Sorry about that. Done.

phra commented 7 years ago

@jefflau sorry but there is a typo in my PR and now the npm package is not working. i've already sent a PR to fix it and you should merge and ship it ASAP. :ship: