Import jest types rather than duplicating, change mockResponses

jefflau / jest-fetch-mock

Jest mock for fetch

MIT License

886 stars 117 forks source link

Closed EButlerIV closed 6 years ago

EButlerIV commented 6 years ago

https://github.com/jefflau/jest-fetch-mock/pull/71#pullrequestreview-127277552 brought up a good point re: importing jest's types rather than duplicating them.

https://github.com/jefflau/jest-fetch-mock/issues/70#issuecomment-394534667 noticed that the current mockResponses definition doesn't match the current behavior. Was the type preemptively changed to match a planned change? If not, and this is a mistake, this PR would also fix that.

caseyduquettesc commented 6 years ago

This is unrelated but shouldn't this package have a peerDependency on jest since jest is used?