search

jefflau / jest-fetch-mock

Jest mock for fetch
MIT License
886 stars 117 forks source link

Move @typings/jest to devDependencies #84

Closed shtaft closed 6 years ago

shtaft commented 6 years ago

Since jest functions are global, their typing tends to conflict with other global values in global space. This commit moves jest typings to devDependencies, where they won't be included for projects that require jest-fetch-mock.

This is very similar to a protractor issue, references here- https://github.com/angular/protractor/issues/3792 https://github.com/angular/protractor/pull/3795

shtaft commented 6 years ago

@jefflau possible to get this in soonish? These type collisions are blocking us from uptaking your fabulous library!

jefflau commented 6 years ago

Apologies, I've been rather busy as of late. I will merge and push this tonight!

shtaft commented 6 years ago

Thanks Jeff!