jefflester / minitrino

A tool that makes it easy to run modular Trino environments locally.
Apache License 2.0
32 stars 3 forks source link

Swap internal and external ports in docker-compose.yml files #35

Closed jefflester closed 3 years ago

jefflester commented 3 years ago

Currently, certain modules lead to port conflicts when provisioned together (the delta-lake and hive-minio modules will cause this, for example). This is because the external and internal port mappings are backwards.

Current port mappings look like:

    ports:
      - "9083:9084"

This makes the external port 9083 and the internal port 9084. Plenty of other metastore services exist in the modules, so any module with a metastore provisioned at the same time will result in host-level port conflicts. This can be resolved by simply flipping the mapping:

    ports:
      - "9084:9083"

This way, the service will be exposed on the host on port 9084, and the internal service will still be accessible on port 9083.