search

jefflester / minitrino

A tool that makes it easy to run modular Trino environments locally.
Apache License 2.0
32 stars 3 forks source link

Miscellaneous Functionality Cleanup #52

Closed jefflester closed 1 year ago

jefflester commented 1 year ago

A few things could be touched up in Minitrino:

  1. Instead of using bootstrap scripts for config.properties management, we could use a more user-friendly approach involving environment variables defined in the Compose YAML. Something like:
trino:
  environment:
    CONFIG_PROPERTIES: |-
      insights.jdbc.url=jdbc:postgresql://postgres-query-logger:5432/querylogger
      insights.jdbc.user=admin
      insights.jdbc.password=trinoRocks15
      insights.persistence-enabled=true
      insights.metrics-persistence-enabled=true

We'd merge these together based on the presence of configured properties in whatever modules the user wants to provision, then either run an automated script inside the Trino container or mount the collection of properties as a cohesive config.properties file to the container.

We'd want to keep the existing bootstrap functionality around while simultaneously decoupling it from managing this config file.

  1. Remove CLI support for CONFIG and JVM_CONFIG environment variables (see: readme). This is messy and buggy in the first place, and by implementing the 1st request above, there would be little to no need to support these variables.
jefflester commented 1 year ago

Closed with #56