User Authentication - Githubissues

jeffliang0318 / Jtsy

Clone Etsy

10 stars 1 forks source link

User Authentication #8

Closed jeffliang0318 closed 6 years ago

jeffliang0318 commented 6 years ago

[x] Backend: DB, model, controller, views
[x] Redux Loop: ajax, actions, reducers
[x] Presentational Components
[x] Demo User Added
[x] Styling
[x] Smooth, bug free navigation
- [x] Login errors clears when switching from login form to sign up form (and vice-versa)
[x] Adequate and appropriate seeds

jeffliang0318 commented 6 years ago

Should be all good, will working on more styling later

xnanodax commented 6 years ago

[x] Also, if I were to acccess a bogus page like localhost:3000/jdfklajsdklfjalksdf, I should be redirected to a page like "localhost:3000/" hint: redirect

jeffliang0318 commented 6 years ago

update: redirect to index page

xnanodax commented 6 years ago

Great work so far :)!

[ ] When hovering over a link or button, the pointer should turn into a pointing hand instead of the default mouse cursor.
[x] Render the errors in a different color. They are currently black.
[x] Add more padding in the modal session/login form
[ ] Typically modal have a "X" on the corner to close the modal.
[x] On the register page, the login button shouldn't be next to the Register header. It is confusing for the user what this page is doing.

xnanodax commented 6 years ago

[x] When logging in, I currently see this error on the console:
[x] Receiving a 500 level error when using the demo login.
[x] Cannot log out of the site.
[x] Sign in form should look more similar to the Etsy's. You can ignore the facebook google login buttons.

xnanodax commented 6 years ago

Hey Jeff :) Let's update some of the styling and then we can close off this issue! Thank you!

jeffliang0318 commented 6 years ago

I think it is better now...

xnanodax commented 6 years ago

Great work :)! Still some styling notes outlined above in case you want to come back and refactor. Great styling updates :)!