search

jefflinse / pr-semver-bump

A GitHub Action to bump and tag a new semantic version when a pull request is merged.
MIT License
24 stars 11 forks source link

Ability to use git operations rather than github api #31

Open benhowes opened 2 years ago

benhowes commented 2 years ago

I ideally want to use pushing a new tag as a trigger for a second part of my release code. I can currently do that by using a personal access token, but there is a potential second option outlined here. In short, by creating a deploy key with write access, one can push changes and trigger workflows.

I've explained in a little more detail in my fork of this project https://github.com/Spatial-Quotient/pr-semver-bump#adds-use-ssh-option

Would you consider a PR to add this as an option? I'd love to be able to avoid using a personal access token for my use-case :)

siggimoo commented 2 years ago

Both changes make sense to me. @jefflinse, your thoughts?

jefflinse commented 2 years ago

Supporting the deploy-key scenario is definitely a feature we should incorporate. Thanks for proposing! Feel free to use the implementation in your fork as a starting point for a PR, otherwise I can likely get to this later this week.

Regarding a require-release flag (or similar), I can see how this would be useful, but I'd also like to be a little more comprehensive and allow users to define one or more GitHub tags that can be used to specify a "no-bump" scenario. For example, Documentation, New New Version, etc. I've opened https://github.com/jefflinse/pr-semver-bump/issues/32 to track this separately.