search

jefflinwood / twilio_client_phonegap

Phonegap plugins for the Twilio Client iOS and Android SDKs
MIT License
59 stars 53 forks source link

Included SDKs in the plugin #16

Closed peder541 closed 5 years ago

peder541 commented 9 years ago

The Twilio Client SDK files are in the sdk folder and separated by platform. plugin.xml makes sure these source files get installed in the correct location and linked properly.

jefflinwood commented 9 years ago

Hi,

This is great - can you just include the acknowledgements.txt and the README into the pull request as well?

peder541 commented 9 years ago

Sure thing. Since the README links to other files, do you think those should be included too?

jefflinwood commented 9 years ago

That's my thought. I don't think it needs the starter apps or the helper libraries though.

peder541 commented 9 years ago

Jeff, have you had a change to look at this?

jefflinwood commented 9 years ago

Hi, somehow I missed the update you put in! Let me take another look.

peder541 commented 9 years ago

Twilio released updated SDKs today that fix some important bugs, especially for Android. I thought it would be good to include them in this pull request.

jefflinwood commented 9 years ago

I definitely agree there should be the latest versions of the SDKs in this plugin - and perhaps the plugin versioning should match the SDK versioning - maybe 1.2.2.1, for instance?

peder541 commented 9 years ago

I think that style of versioning makes a lot of sense. Do you know if the Cordova Plugin Registry would support four digits in the version number like that?

jefflinwood commented 9 years ago

That I don't know - I'm also not sure if this would be eligible for the PhoneGap Build, but that would be great as well

sb8244 commented 8 years ago

Hi, this PR makes it possible to use twilio client phonegap in an ionic build. Ionic builds the xcodeproj for you, and including the libraries there can be a real PITA (haven't figured out how to do it yet).

peder541 commented 8 years ago

Any chance we can resolve this?

northkode commented 7 years ago

Is this going to get merged? What is the status of master? are the memory and destroy issues fixed?