Closed brandtdaniels closed 11 years ago
There is a bug in copy-roms.sh
sudo umount /mnt/removeable
there is no such mount-point.
it should be
sudo umount $SOURCE
Updated copy-roms.sh
export HOME="/home/pi"
SOURCE="/mnt/usbdisk" TARGET="/home/pi/roms" SYSLOG="/var/log/syslog"
if [ -d "$TARGET" ]; then rm -rf $TARGET/* fi if [ -d "$SOURCE" ]; then
find $SOURCE -type f ( -name ".nes" -o -name ".NES" -o -name ".Nes" ) -a ( ! -regex './..*' ) -exec cp {} $TARGET \; sudo chown -R pi:pi $HOME/roms echo "Copied ROMs to $TARGET" >> $SYSLOG
sudo umount $SOURCE killall glint-es && /home/pi/glint-es/glint-es & else echo "ERR: $SOURCE does not exist." exit 1 fi
exit 0
Tagged a new release v0.1.1-beta
with this bug fix.
Opened a separate case regarding the red text - #37. Let's keep issues as fine-grained and self-contained as possible. This case, as originally submitted, is actually two cases.
Enhancement:
The text says 'Add ROMs via USB stick' on the top in red. I think the text should be centered vertically and be better descriptive of how to add roms. Also something other than a USB stick could be used such as a hard drive. I would suggest the text be something like 'Please insert USB device containing ROM images'
Bug:
After ES restarted and the list of ROMs were displayed. There was still the red text at the top asking to add roms.