search

jefflunt / rpglogger

(retired) Build your own strategy guide for any RPG
6 stars 0 forks source link

Sort order on columns isn't reflected in forms #109

Closed jefflunt closed 12 years ago

jefflunt commented 12 years ago
  1. The sort order on Section pages isn't reflected in the forms you use to add/edit objects.
  2. The sort order on Section edit pages isn't reflected in the form you use to edit the Section attributes
jefflunt commented 12 years ago

Steps:

  1. Add sort_order column to WorldObjectProperty model
  2. Add validates :presence constraint
  3. Migration must copy sort_order value from related SectionProperty record
  4. Write test to confirm that sort_order is changed on WorldObjectProperty model when it's changed on the related SectionProperty
  5. Setup before_save filter on SectionProperty to update the child WorldObjectProperty records
jefflunt commented 12 years ago

Confirmed working in production. Closing.

jefflunt commented 12 years ago

The sort order, when adding NEW columns to an existing section, is done wrong. The new column headings get displayed in the correct order, but either new attributes aren't being generated, or they aren't being assigned the correct (or possibly any) sort order, resulting in the attribute values themselves being shown incorrectly.

jefflunt commented 12 years ago

Appear to be fully fixed on production.