Closed jefflunt closed 12 years ago
All the tests are passing again.
The show/hiding of deleted WorldObjects in sections is broken for some reason. I opened issue #149 to address this.
One of the most common things that I found that was breaking scenarios was the use of <i>
tags to display the delete/show/restore links. This really shouldn't be. If you want to use a DOM element that has a certain class to then display an icon via CSS, then a <span>
or <div>
element should be used instead, where appropriate. As a result I replaced these instances with the original UTF-8 characters, and cleaned up the views significantly via the addition of several helper methods.
I hope the commits are explanatory enough to cover what I changed, and why I changed it.
There's still some font and color consistency to work on, as the current, test-passing layout essentially looks the way it did before I started working on the tests.
The new layout has the latest changes from the removal of the paranoia gem, all the tests are passing and my initial testing seems to show good results at this stage.
Take advantage of Bourbon to handle complex and browser-specific CSS stuff: http://thoughtbot.com/bourbon/
Many of the changes that I'd like to see are going to be done later. I've decided to deploy the layout in its current state, which updates colors, resolved the Cucumber scenario issues, and some other things. Tweaks can be make later to spacing, flash messages, etc.
What I've done is merge David's changes into master, merged those changes into a new branch
layout-changes-merge
, and then reverted the merge on master. The current state of things requires full testing before deployment, so I need to keep the master branch unchanged for now.Some immediate issues:
What I like about the updates to the layout:
Some additional changes I expect to make to the layout (just off the top of my head, after briefly looking at the new layout):
Overall, I feel that the direction the new layout is taking is definitely an improvement.
I haven't yet tested the proposed fixes to issues #46 and #48. After I repair the cucumber scenarios I'll begin looking into these. As a result of how I merged, then moved, then reverted the master branch, issues #46 and #48 were closed then reopened. This was intentional.