search

jeffmer / TTGO-T-watch-2020-Micropython-OS

All micropython watch software for TTGO T-watch 2020 V1, V2 & V3
The Unlicense
19 stars 5 forks source link

Install Script has wrong version #20

Open scott8 opened 6 months ago

scott8 commented 6 months ago

The install script checks for version 3 before installing GPS-related code. It should be version 2.

easytarget commented 5 months ago

Looking at this; it is a negated test; https://github.com/jeffmer/TTGO-T-watch-2020-Micropython-OS/blob/359a0da3b35ed387ca1e3e3780a01fdb4640dc2a/src/install.sh#L69 ..so V1 and V2 boards get the GPS stuff but not V3? I'm confused. Only V2 has GPS. Why construct the test this way? afik it should be: if [[ $(grep -Rl 'VERSION = 2' config.py) == "config.py" ]]