jeffminton / keyboard_stl_generator

Generate a 3D model from a keyboard design from keyboard layout editor and split up the design so it can be printed on a 3D printer
GNU Affero General Public License v3.0
107 stars 8 forks source link

Missing angled keys and some artefacts #5

Closed pvcdx closed 2 years ago

pvcdx commented 2 years ago

Hello,

testing the included layouts, command

./keyboard_stl_generator.py -a -i layout_files/ergodox_named.json

produces files that render with extra lines the width of the whole keyboard, and the angled thumb cluster keys missing

ergodox_named_section_0_all 1

Could You please have a look at it?

jeffminton commented 2 years ago

Yes I see the issue as well. I will work on it when I get some time and let you know when to try again

jeffminton commented 2 years ago

I believe I have corrected the issue. Please try it again

pvcdx commented 2 years ago

Thank You for the quick reply.

The thumb cluster appeared, but the two walls, crossing the printer board size boundary, are still there: ergodox_named_section_0_all 2

jeffminton commented 2 years ago

I put up another change that should address those bars that are showing up

pvcdx commented 2 years ago

The bars are fixed also..

Thank You!