search

jeffminton / keyboard_stl_generator

Generate a 3D model from a keyboard design from keyboard layout editor and split up the design so it can be printed on a 3D printer
GNU Affero General Public License v3.0
105 stars 8 forks source link

Generate missing case part when splitting keyboard. #8

Open Michal-Szczepaniak opened 1 year ago

Michal-Szczepaniak commented 1 year ago

When splitting keyboard, for simplicity in two, there's gap in the case in both of them, because they're ment to be glued together. Could it be possible to have some option to generate case wall in that empty hole? so that the two halves will work as split keyboard?

Also, would it be possible to specify where the split occurs? If i set smaller print bed size i can force first part to be split in correct spot but then second part is being also split.

Both of these feature requests are in view of creating split keyboard instead of connecting two parts afterwards, something like this image https://www.thingiverse.com/thing:2402102 so that two halves can work both as split keyboard and as entire keyboard.

jeffminton commented 1 year ago

This might be possible but it would probably be a fairly complex addition. It would also require that the user provide a lot more information in the parameters to define the split area. I will keep this as a feature request for potentially future implementation.

Michal-Szczepaniak commented 1 year ago

But generating missing case part shouldn't be too complicated right?

jeffminton commented 1 year ago

It is not that straightforward due to the way I have built the logic to split up the prart for printing. It doesn't see space between keys as anything different that spaces where keys exist. I would have to add logic where based on a parameter the user passes in I could know to treat a break in the middle as a separate space to create instead of the automatic splitting based only on size as I am doing now.