search

jeffp123 / spray

An open-source speed-reading application written in Javascript
66 stars 18 forks source link

Words with a length of more than 15 characters generate errors #6

Open 4skinSkywalker opened 7 years ago

4skinSkywalker commented 7 years ago

Words with a length of more than 15 characters generate errors

jeffpeck-intellify commented 7 years ago

Care to post the errors?

4skinSkywalker commented 7 years ago

I pasted this text "aaaaaaaaaaaaaaaaaaaaa" inside the demo I downloaded from GitHub and the error in the console is:

Uncaught RangeError: Invalid array length at String.repeat (spray-reader.js:156) at pivot (spray-reader.js:133) at SprayReader.displayWordAndIncrement (spray-reader.js:81) at spray-reader.js:68

When I click to reavel the part of script that generated it, the source code shows: String.prototype.repeat = function( num ){ return new Array( num + 1 ).join( this ); //highlighted }

I've fixed this for my webapp not using the piece of code that generates dots (right-weighted stuff for long words I think). I imagine you assume that because words have the root of the meaning in the left-most part, shifting a bit the middle point of focus would be a good idea, and I think this too for English! But for example, in Italian if you missed a part of a composed words the meaning become almost impossible to understand and it can be also very misleading, because in Italian we use many already existent words put togheter to mean something else. The word "autoferrotranviario" it's an example of compound word, it means "train" but if you only read "auto..." then the significate is "car" a that's a big difference.