Save HD doesn't work on Chrome - can improve with Blob/URL

jeffpar / pcjs.v1

PCjs Machines 1.0 (archived)

https://github.com/jeffpar/pcjs.org

GNU General Public License v3.0

475 stars 92 forks source link

Closed mihailik closed 6 years ago

mihailik commented 6 years ago

Save HD button doesn't work on Chrome - quick check suggested due to data URI being too large.

A better more scalable approach would be to use Blob and URL - will also skip unnecessary base64 encode in this case.

I'm trying to implement a PR for that at the moment, actually. Hope to submit soon.

jeffpar commented 6 years ago

I’m assuming we can consider this fixed now, thanks to you.