search

jeffpar / pcjs.v1

PCjs Machines 1.0 (archived)
https://github.com/jeffpar/pcjs.org
GNU General Public License v3.0
474 stars 92 forks source link

Fullscreen has weird behavior on Chrome #79

Closed Sgeo closed 5 years ago

Sgeo commented 5 years ago

On Chrome 75 on Windows, the fullscreen button seems to leave a lot of the virtual screen off of the visible screen. On Firefox, the fullscreen button seems fine, and there are black bars at the edges of the screen, which I assume is aspect ratio related?

jeffpar commented 5 years ago

Ah, the joy of keeping up with browser changes. It looks like Chrome (and Edge) have altered their fullscreen support to behave more like Firefox. Safari is still a holdout, so I still must have two different code paths for scaling the canvas in fullscreen mode. Hopefully if/when Safari ever changes too, it will also define the standard fullscreenEnabled property, which will automatically trigger the new behavior. And hopefully Edge will define that someday as well, so that I don't have to explicitly check the agent string for "Edge". sigh

I've bumped the PCx86 version to 1.75.4, so make sure you're running the latest version, and let me know if your problem is resolved. It should be....

Sgeo commented 5 years ago

Tested on main pcjs.org website, works fine now, thank you :).