search

jeffpar / pcjs

The original IBM PC and other machine emulations in JavaScript
https://www.pcjs.org
Other
822 stars 124 forks source link

Add docker support #31

Closed brainrecall closed 1 year ago

brainrecall commented 2 years ago

Hi! First off, I wanted to thank you for this project. This is amazing work. I was attempting to restore a Xerox 6060, which is a cousin of the AT&T 6300, and I was having multiple hardware issues. Your project gave me pretty much everything in one place. But I wanted to run my own instance of your work, and I've been on a container-kick for awhile and decided to take a stab at running PCjs in a docker container.

The files I created are very simple; I leverage the official jekyll docker image for all of the complicated stuff. Despite everything looking simple, it was a lot of trial-and-error at figuring out what was needed and what wasn't.

What I don't have in this pull request, though, is modifications to the Wiki. The build instructions are slightly different:

  1. Clone this repository onto your computer
  2. Install docker-compose
  3. In the root of this repository, run docker-compose build
  4. Run docker-compose up to start the web server

The one issue I've seen so far is the "PCjs Machines" link in the top-left links to 0.0.0.0, which I'm not sure why. Otherwise, it seems to run great.

Thanks again!

jeffpar commented 1 year ago

Sorry I never followed up on this, better late than never I guess. Trying to be more proactive this year. Thanks.

brainrecall commented 1 year ago

No problem, thanks for merging!