jeffrey-jian / pe

0 stars 0 forks source link

Wrong Error message attempting to edit a TA's name to an existing name #9

Open jeffrey-jian opened 12 months ago

jeffrey-jian commented 12 months ago

Steps to reproduce

  1. Have a TA entry named "Alex Yeoh" in the app.
  2. Have another TA entry in the app.
  3. Execute edit 2 n/ Alex Toh p/93812311 e/test@test.com tel/@raynertjx h/4 t/parttime c/CS2103T command on the 2nd TA, and change his name to Alex Yeoh.

Expected Result

Error message says that Alex Yeoh already exists in the system.

Actual Outcome

Emails should be of the format local-part@domain and adhere to the following constraints:

  1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may >not start or end with any special characters.
  2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods. The domain name must:
    • end with a domain label at least 2 characters long
    • have each domain label start and end with alphanumeric characters
    • have each domain label consist of alphanumeric characters, separated only by hyphens, if any.

This error message tells me that my email format is wrong, even though the format is correct. Attempted to edit the email to a more sensible one with proper domain name, yet it still shows that the email format is wrong.

Screenshot 2023-11-17 at 4.58.11 PM.png

nus-pe-bot commented 12 months ago

Team's Response

There is a typo in the command edit 2 n/ Alex Toh p/93812311 e/test@test.com tel/@raynertjx h/4 t/parttime c/CS2103T

Instead of "tel" it should be "tele" according to our UG.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]