search

jeffreydwalter / ColReorderWithResize

Column reordering and resizing plug-in for DataTables
http://www.datatables.net/
MIT License
42 stars 51 forks source link

Missing comma #10

Closed Martskin closed 6 years ago

Martskin commented 6 years ago

Somewhere in the merge of the last PR a comma was dropped after allowResize: true. It's causing a Uncaught SyntaxError: Unexpected identifier error.

https://github.com/jeffreydwalter/ColReorderWithResize/blob/master/ColReorderWithResize.js#L1620

Martskin commented 6 years ago

Looks like the problem was introduced here: https://github.com/jeffreydwalter/ColReorderWithResize/commit/bdf5603bf3b04b96256fa04daefec89443038de9#diff-e6c39dd5a8cd09bff9a661112649a7e7R1618

jeffreydwalter commented 6 years ago

Yeah, had to manually merge your work into mine because of the whitespace changes. I'll fix that comma later today.

Thanks!

On Fri, Jun 29, 2018, 10:57 AM Martin Hofmann notifications@github.com wrote:

Looks like the problem was introduced here: bdf5603#diff-e6c39dd5a8cd09bff9a661112649a7e7R1618 https://github.com/jeffreydwalter/ColReorderWithResize/commit/bdf5603bf3b04b96256fa04daefec89443038de9#diff-e6c39dd5a8cd09bff9a661112649a7e7R1618

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jeffreydwalter/ColReorderWithResize/issues/10#issuecomment-401398000, or mute the thread https://github.com/notifications/unsubscribe-auth/AAinBwcNEONARpsBgeLBY74fY_Fo2qbBks5uBk59gaJpZM4U9O_m .

jeffreydwalter commented 6 years ago

Fixed that! Sorry about it and thanks again for your help!

Martskin commented 6 years ago

Thanks! Glad to help.