code cleanup - Githubissues

mewalig commented 5 years ago

I'd like to clean up this code base because

I'd like to use it
I'd like to modify it and
it will be much easier to use and much easier to modify if we clean it up first

For example:

there are 16 unused variables. this creates unnecessary confusion, especially with the similar naming conventions
there are various redundant snippets of code that can be consolidated into reusable functions
there are a number of implied globals which will raise errors if we put the code through a strict parser

I'd like to fix all of these and submit them back into a pull request.

In addition, I'd like to convert this to typescript and gradually add in the various type checking and other benefits that Typescript offers.

All of the above will be a lot of changes but I'm sure will make this project a lot more valuable to others. Will you accept these changes if I put them all into a pull request? Alternatively, if you prefer, I can just fork this and make the changes there, and we can leave them as separate forked repos.

jeffreydwalter commented 5 years ago

Hello! I'm happy to have your help. If you're interested, if be happy to make you a maintainer.

mewalig commented 5 years ago

Sure, please add me as a maintainer and I'll make the changes directly (or lmk if you'd like me to run them by you first)

jeffreydwalter commented 5 years ago

Great! I add you as a collaborator. Please let me know if you don't get the invite.

Thanks for your help! I just don't have time to do much on this plugin these days, so it's very appreciated!

On Sat, Mar 16, 2019 at 5:56 PM mewalig notifications@github.com wrote:

Sure, please add me as a maintainer and I'll make the changes directly (or lmk if you'd like me to run them by you first)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jeffreydwalter/ColReorderWithResize/issues/21#issuecomment-473599429, or mute the thread https://github.com/notifications/unsubscribe-auth/AAinBz2CxbdpornF6H59jb99hAocV2Vqks5vXXa5gaJpZM4b3J59 .

jeffreydwalter commented 5 years ago

@mewalig are you still interested in helping out with this repo?

jeffreydwalter / ColReorderWithResize

code cleanup #21