search

jeffreydwalter / arlo-go

WIP - (BETA) - Go package for interacting with Netgear's Arlo camera system.
MIT License
43 stars 8 forks source link

Fix the code example in the README #5

Closed jryd closed 5 years ago

jryd commented 5 years ago

The example for downloading files doesn't match the parameters we need to provide for the DownloadFile method.

We need to provide an actual file, not the name to the file we want to write.

I agree with the current implementation of the DownloadFile method where creating the file shouldn't be the responsibility of this library. The user can create their own file in whatever directory they like and then just pass the reference to this and we can stream the video contents into it.

jeffreydwalter commented 5 years ago

Ah yeah... I updated the function and neglected to update the example. Great catch and thank you!