search

jeffreydwalter / arlo

Python module for interacting with Netgear's Arlo camera system.
Apache License 2.0
520 stars 123 forks source link

Name 'requests' is not defined #109

Closed rnorth closed 5 years ago

rnorth commented 5 years ago

Thanks for this useful library! I've encountered what is probably just a simple issue affecting the latest versions.

What version of Python are you using (python -V)?

3.6.8

What operating system and processor architecture are you using (python -c 'import platform; print(platform.uname());')?

uname_result(system='Linux', node='dca5b8fcc182', release='4.9.125-linuxkit', version='#1 SMP Fri Sep 7 08:20:28 UTC 2018', machine='x86_64', processor='')

Which Python packages do you have installed (run the pip freeze or pip3 freeze command and paste output)?

arlo==1.2.17
certifi==2018.11.29
chardet==3.0.4
idna==2.8
monotonic==1.5
PySocks==1.6.8
requests==2.21.0
six==1.12.0
sseclient==0.0.22
urllib3==1.24.1

Which Arlo hardware do you have (camera types - [Arlo, Pro, Q, etc.], basestation model, etc.)?

n/a

What did you do?

Ran a script which is fairly similar to arlo-download.py

What did you expect to see?

The script should download new videos.

What did you see instead?

name 'requests' is not defined is thrown.

It seems that the import for requests was removed in this commit but usages of requests in GetRecording and StreamRecording were not refactored (e.g. https://github.com/jeffreydwalter/arlo/blob/master/arlo.py#L1376)

Does this issue reproduce with the latest release?

Yes

jeffreydwalter commented 5 years ago

Good catch! Fixed in the latest release. Thanks!