jeffreydwalter / arlo

Python module for interacting with Netgear's Arlo camera system.
Apache License 2.0
520 stars 123 forks source link

Multiple type filter #126

Closed robweber closed 5 years ago

robweber commented 5 years ago

As discussed in #125

This will allow for filtering on multiple device types in a single GetDevices call by passing in a list of types. A string is still acceptable to maintain backwards compatibility.

Filtering on provisioned or unprovided devices can be done by passing in a True/False value. Default (None) will do no filtering on the state of the device. This part of the code isn't quite as clean as if the user could specify a state string to filter on. However, I think it's unlikely users will be easily aware of the exact state values to pass in. The True/False value makes it easier on the end user. If you'd rather see this part done a different way let me know.