search

jeffreykegler / libmarpa

Marpa parse engine C library -- STABLE
MIT License
97 stars 11 forks source link

Significance of earley set id parameter to marpa_b_new unclear #84

Closed dabrahams closed 2 years ago

dabrahams commented 2 years ago

Presumably marpa_b_new returns a bocage containing all valid parse trees ending at that earley set (and starting where?), but it's never quite specified.

Note: calling the parameter earley_set_id is a missed opportunity to communicate something useful about its meaning. Not a substitute for fixing this issue, but it could help.

jeffreykegler commented 2 years ago

Fixed as of commit https://github.com/jeffreykegler/libmarpa/commit/c484ea432540e6c012925ce770b6ed13e08b2d87. Absent feedback to the contrary, I will close this issue after a couple of days.

jeffreykegler commented 2 years ago

Closed as per https://github.com/jeffreykegler/libmarpa/issues/84#issuecomment-1187945712.