jeffreykegler / yahc

Yet Another Hoon Compiler
MIT License
0 stars 1 forks source link

Cencab anomalies? #10

Closed jeffreykegler closed 5 years ago

jeffreykegler commented 5 years ago

Below is a file of cencab violations of our current jogging standards. These all do look like real anomalies, and for inclusion in anomaly.suppression, with one possible exception: In hall.hoon, there seems to be an alternative "flatwards" strategy, not allowed under our current standard.

@ohAitch: Let me know what you think.

cencab.lint.txt

ohAitch commented 5 years ago

Yep, real anomalies. The flatwards sections aren't even super aligned!

On Thursday, 14 February 2019, Jeffrey Kegler notifications@github.com wrote:

Below is a file of cencab violations of our current jogging standards. These all do look like real anomalies, and for inclusion in anomaly.suppression, with one possible exception: In hall.hoon, there seems to be an alternative "flatwards" strategy, not allowed under our current standard.

@ohAitch https://github.com/ohAitch: Let me know what you think.

cencab.lint.txt https://github.com/jeffreykegler/yahc/files/2866215/cencab.lint.txt

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jeffreykegler/yahc/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxXhr25RKvvS6OCR6laLzcuEiBgpzoDks5vNaF5gaJpZM4a8HdK .

jeffreykegler commented 5 years ago

With the above referenced commit, this issue to ready to be closed. Unless I hear otherwise, I will close it shortly.

@ohAitch I've created some custom labels for this projects. Black&white "Issue for Jeffrey" means the "ball is in my court" on an issue, which is the normal state of things. Yellow "Ready to be closed" is for issues like this. There's also a green "Question from Jeffrey" label, meaning I have some sort of question related to the issue.

jeffreykegler commented 5 years ago

Closed for the reason given in the previous comment.