search

jeffreykegler / yahc

Yet Another Hoon Compiler
MIT License
0 stars 1 forks source link

Missing comments between battery cells #22

Closed jeffreykegler closed 5 years ago

jeffreykegler commented 5 years ago

@ohAitch -- Here's about a dozen missing comments between battery cells. I think these are all anomalies. Agree?

whap5d.lint.txt

ohAitch commented 5 years ago

There appear to be considerably more >s than corresponding !s in the lint output; but I can certainly confirm that blank lines should not be allowed anywhere in hoon! (Okay strictly speaking .udon embeds will near-inescapably have it, but udon is an abomination wrought by two people both of whom are no longer at the company - tbf me and Curtis)

The doubly-commented block it's also complaining about is interesting, the outer outdented comment layer should just not be there; but lint-wise just complaining about it violating indentation seems correct.

On Thursday, 7 March 2019, Jeffrey Kegler notifications@github.com wrote:

@ohAitch https://github.com/ohAitch -- Here's about a dozen missing comments between battery cells. I think these are all anomalies. Agree?

whap5d.lint.txt https://github.com/jeffreykegler/yahc/files/2943253/whap5d.lint.txt

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jeffreykegler/yahc/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxXhoK1wYgsSkuMl9fULwBDwKCDFjG5ks5vUXlRgaJpZM4bkEM2 .

jeffreykegler commented 5 years ago

Added suppressions in last 2 commits, but suppressions apparently already taken care of in other work. Marking as "ready to be closed".

jeffreykegler commented 5 years ago

Closed as per the above.