jeffreykegler / yahc

Yet Another Hoon Compiler
MIT License
0 stars 1 forks source link

Always allow column 1 comments? #39

Closed jeffreykegler closed 5 years ago

jeffreykegler commented 5 years ago

I think it may be a good idea to always allow column 1 comments. These are used in 181 places, for things like commenting out code, meta-remarks, etc. This seems like an eminently reasonable thing for the coders to be doing.

Here is one example, from app/gmail.hoon:

  ::  Subscription request
::    ++  listen
::      ^+  .
::      =+  events=?>(?=([@ @ *] pax) t.t.pax)
::      |-  ^+  +>.$
::      ?~  events
::        +>.$
::      ?:  (~(has by web-hooks) i.events)                ::  if hook exists
::        =.  +>.$  (update-hook i.events)
::        $(events t.events)
::      =.  +>.$  (create-hook i.events)
::      $(events t.events)
    ::

@ohAitch -- do you agree?

ohAitch commented 5 years ago

Yup, I think a bunch of editors have a "block line comment" function that has been employed, including I suppose vim; seems like a good exception to have.

jeffreykegler commented 5 years ago

Fixed in commit a1fadc4. Marking "ready to be closed"

jeffreykegler commented 5 years ago

Closed as per the above.