search

jeffreykemp / jk64-plugin-reportmap

Report Google Map APEX Plugin
https://jeffreykemp.github.io/jk64-plugin-reportmap/
MIT License
42 stars 16 forks source link

Render labels on pins #33

Closed jeffreykemp closed 7 years ago

jeffreykemp commented 7 years ago

As extra optional column in query

suggested by Lucas Hirschegger

lucashir commented 7 years ago

I have prepare the code, but reusing the ID as a label (while truncating it to 1 char). Did you think it is better to have a separate column for that? Thanks

jeffreykemp commented 7 years ago

It will definitely be better as a separate column.

lucashir commented 7 years ago

Hi, I have adapted the code for a separate column. Funny is, that works only when debug mode, otherwise the marker is not created. On my first manual implementation happens, that the map was rendered before the markers were created. I solved it executing the fitBounds after the Markers... Any idea here?

lucashir commented 7 years ago

It works now, typo on the min js file. Seems like I cannot push the changes to a new branch. Should I send it to you directly?

jeffreykemp commented 7 years ago

if you like

On 24 November 2016 at 16:57, lucashir notifications@github.com wrote:

It works now, typo on the min js file. Seems like I cannot push the changes to a new branch. Should I send it to you directly?

lucashir commented 7 years ago

Here you have. Thanks!

jk64-plugin-reportmap.zip

jeffreykemp commented 7 years ago

Thanks Lucas. I have added your changes as v0.7.3 with a slight modification.

In order to not break existing code that may use the flex fields, we can't insert a new column at that point; instead, I've made the "label" a special usage of Flex Field 1. To enable flex field 1 as a label, you need to set the new plugin property "Attribute1" to "Label".

Also, to make the plugin easier to use I've modified the code to truncate the label to 1 character instead of raising an exception.

Please import the new version and let me know if it works ok for you.

Thanks again for your contribution.

lucashir commented 7 years ago

Sorry for the late reply. Can you please check if you commit the wrong version? I still see my -20001exception in the file. Thank you!

jeffreykemp commented 7 years ago

Sorry about that, I must have exported the wrong version. I've released 0.7.3 with the correct version I believe. https://github.com/jeffreykemp/jk64-plugin-reportmap/releases/tag/v0.7.3