search

jeffreylanters / react-unity-webgl

React Unity WebGL provides a modern solution for embedding Unity WebGL builds in your React Application while providing advanced APIs for two way communication and interaction between Unity and React.
https://react-unity-webgl.dev
Apache License 2.0
1.75k stars 162 forks source link

fix: update webGLContextAttributes powerPreference type #545

Closed forforfos closed 8 months ago

forforfos commented 9 months ago

This PR is an addition to https://github.com/jeffreylanters/react-unity-webgl/pull/543

It updates the Type of the powerPreference attribute from the unityConfig object webglContextAttributes.

This attribute accepts the values of 0, 1 and 2 instead of 'default', 'low-power' and 'high-performance'.

forforfos commented 8 months ago

@jeffreylanters Hello! I was wondering if there is something missing so as to merge this PR.

jeffreylanters commented 8 months ago

Excuse me @forforfos, I've had a lot going on privately, so release the PR was delayed a bit. I'll merge and release it this week. Thanks for checking with me! 🙌🏼

jeffreylanters commented 8 months ago

Released in https://github.com/jeffreylanters/react-unity-webgl/releases/tag/v9.5.1

Thanks for your contribution!

forforfos commented 8 months ago

Excuse me @forforfos, I've had a lot going on privately, so release the PR was delayed a bit. I'll merge and release it this week. Thanks for checking with me! 🙌🏼

No worries friend! I was just wondering if I was missing something to complete the PR!

Thank you very much for your time and feedback! <3

On a separate matter, if you have time, check this out at some point! https://github.com/jeffreylanters/react-unity-webgl/discussions/544 I would really like to implement it, and it is really fast and easy I think!

kisses