jeffreytjs / pe

0 stars 0 forks source link

Duplicated entries are not detected #1

Open jeffreytjs opened 3 years ago

jeffreytjs commented 3 years ago

When adding a new log, the same command is repeated and they are all accepted. While all other fields can be repeatable, it should not allow the same datetime to be entered realistically.

Steps to recreate:

  1. Start up app
  2. Enter add e/Sit ups r/1 c/my abs hurt :( repeatedly

image.png

nus-se-bot commented 3 years ago

Team's Response

They are not duplicate since the date and time of the logs are different, just that the seconds are not fully displayed in the UI.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I would like to reject the team's response on the basis that the team's intended usage of the app can be conflicting and counter-intuitive.

There is an assumption that users should guess that the entries differ by seconds, but typical users wouldn't really consider to the seconds as long as the app works. Also, are users suppose to intentionally wait for some expected time to pass before recording the next exercise for the logs to appear realistic in terms of time? This would prevent effective use of the app if users were to do backlogging where they key in all their completed exercises at one shot.

I would think that there should be some error thrown if users are trying to add the same exercise with the same number of reps within the same timeframe. Unless the user is very motivated in using the app that they would like to record every rep in realtime as soon as they complete the exercise which is not very likely. Therefore, the input of same exercise with same rep is more likely to be an error.