search

jeffreytse / jekyll-deploy-action

🪂 A Github Action to deploy the Jekyll site conveniently for GitHub Pages.
MIT License
339 stars 44 forks source link

Document that the vendor directory must be excluded #69

Open AnyOldName3 opened 9 months ago

AnyOldName3 commented 9 months ago

This line https://github.com/jeffreytse/jekyll-deploy-action/blob/master/entrypoint.sh#L22 causes Bundler to install gems to the vendor subdirectory of the working directory so gems can be cached. However, it also means Jekyll will attempt to include files from gems in the site, potentially leading to errors like https://hjerpbakk.com/blog/2020/05/25/your-site-could-not-be-built for a site that built just fine outside of this action.

Documenting that the vendor directory needs adding to the site's exclude list would be helpful for avoiding and diagnosing this kind of problem.

jeffreytse commented 6 months ago

Hi @AnyOldName3

I'm so sorry for the late reply as my busyness. Thanks for your kind advice, I will try to work on it ASAP.

Thanks & Regards