jeffreytse / jekyll-spaceship

🚀 A Jekyll plugin to provide powerful supports for table, mathjax, plantuml, mermaid, emoji, video, audio, youtube, vimeo, dailymotion, soundcloud, spotify, etc.
MIT License
606 stars 63 forks source link

The table-processor processes pipes (|) that are outside tables #10

Closed brigitte-youitv closed 3 years ago

brigitte-youitv commented 4 years ago

I found a tiny bug - if I have a pipe | somewhere in my text that's not in a table, the text is still seemingly processed by the table-processor.

For example, compare this output without jekyll-spaceship:

image

to this output with jekyll-spaceship:

image

The problem seems to happen regardless of whether or not I surround my | with liquid raw tags. Here is the code I'm using. Note that without jekyll-spaceship I don't need the raw tags, but they don't hinder either. With jekyll-spaceship, I get the same results (depicted above) regardless of whether or not I specify raw.

Tips:
* Use pipes {% raw %}(`|`){% endraw %} to delineate columns, and dashes to delineate the header row from the rest of the table.
* Spacing doesn't matter to the markdown processor, any extra white space is removed, but it can really help with readability.
The two markdown examples below both create this table.
jeffreytse commented 4 years ago

Hi @brigitte-youitv

According to your description, now the problem is addressed and it's escaping code block issue.

Thanks and regards

jeffreytse commented 4 years ago

Hi @brigitte-youitv

🎉 The latest gem version v0.6.3 has been released.

Thanks and regards

brigitte-youitv commented 4 years ago

Ahhh! Thank you so much. You work fast! I'll upgrade and it it a try when I'm back at my computer.

brigitte-youitv commented 4 years ago

Tested and it works! Fantastic again. Thank you.