search

jeffreytse / jekyll-spaceship

🚀 A Jekyll plugin to provide powerful supports for table, mathjax, plantuml, mermaid, emoji, video, audio, youtube, vimeo, dailymotion, soundcloud, spotify, etc.
MIT License
626 stars 67 forks source link

Markdown Jekyll-minimal issue #17

Open ROBOTIS-David opened 4 years ago

ROBOTIS-David commented 4 years ago

HI, I am using 'jekyll-theme-minimal' and Just installed this awesome gem, jekyll-spaceship.

I installed the gem into my config and gem document, and this gem so great !

But, when I created the table, it just break my jekyll layout which I haven't expected.

image

The layout shout be like the below,

The navigation menu and the contents area should be deployed separately. Also, the size of all contents in git page should be automatically resized following the size of the window.

image

If you have any idea or suggestions, it would be so grateful !

Thank you

Best regards,

jeffreytse commented 4 years ago

Hi, @ROBOTIS-David

An example is better than long words, could you attach the jekyll project demonstrating the bug. It's better for me to address the issue.

Thanks with regards .

jeffreytse commented 4 years ago

Hi @ROBOTIS-David

I have test and there was no issues, below is the representation on my side.

image

And I just released the latest version v0.8.4, and this version fixed some issues. You can run bundle update to update it and then try again.

Thanks with regards.

ROBOTIS-David commented 4 years ago

Hi, @jeffreytse

Thank you so much replying to my comment :)

But please note that the current git page does not use the jekyll-spaceship

Regarding the bugs, the broken layout had been generated for my local branch, so that I didn't merge the gem into my master branch unfortunately.

ROBOTIS-David commented 4 years ago

Well @jeffreytse

I just simply retested by installing the gem again, and it works now.

image

I really have no idea why this occurred before :(

But thank you so much for your efforts :)

Btw, when I had applied this gem into my config and gem file. It used to slows down my build time (Like Over 50 secs)

But now, the build time incredibly decreased by 17 secs.

Is it because of the new updates?

Cause I was going not to use this gem after encountering the issue, because of some troubles. But now.. there is no reason not to use this magical feature.

jeffreytse commented 4 years ago

Hi, @ROBOTIS-David

You're welcome. Your good support means my effort is valuable. And welcome to star this open source project for more awesome and magical features in future.

My side also has the same situation, and the build time totally depends on your machine, when the CPU isn't so busy, the build time will be decreased, also, the another reason is the cache of Jekyll building.

Thanks with regards.