jeffreytse / jekyll-spaceship

🚀 A Jekyll plugin to provide powerful supports for table, mathjax, plantuml, mermaid, emoji, video, audio, youtube, vimeo, dailymotion, soundcloud, spotify, etc.
MIT License
626 stars 67 forks source link

Bug: Tables row can have links or images, but not both #20

Closed brigitte-youitv closed 4 years ago

brigitte-youitv commented 4 years ago

I noticed that when I try to add a link to the same table row as an image, that both disappear.

For example, consider this simple table:

[cell-image]: https://jekyllrb.com/img/octojekyll.png "An exemplary image"

| Heading                           | Column 1      | Column 2                           |
|-----------------------------------|---------------|------------------------------------|
| Row 1                             | Apple         | Orange                             |
| Row 2 (merged)                    | Blueberry     | Strawberry                         |
| ^^                                | Plum          | Raspberry ![example][cell-image]   |

image (Screen capture trimmed so this post isn't super long).

The above displays as expected. And if I modify the last line to remove the image and add a link to Plum like this:

| ^^                                | [Plum](https://example.com) | Raspberry                          |

I see the link, no problem. image

But when I add both the link to Plum and the image beside Raspberry, neither appear:

| ^^                                | [Plum](https://example.com) | Raspberry ![example][cell-image]   |

image

I made a little project to show you what I mean (attached zip_bug_both_images_and_links_spaceship.zip). My screen captures above are from this zipped up project. The changes are all on the main page.

jeffreytse commented 4 years ago

Hi @brigitte-youitv

Thanks for your details about this issue, and now this issue was addressed and settled down.

Thanks with regards.

brigitte-youitv commented 4 years ago

Thank you! Updated the bundle and the issue is resolved!