search

jeffreytse / jekyll-spaceship

🚀 A Jekyll plugin to provide powerful supports for table, mathjax, plantuml, mermaid, emoji, video, audio, youtube, vimeo, dailymotion, soundcloud, spotify, etc.
MIT License
626 stars 67 forks source link

Fix multiple colspans within same row #4

Closed willflet closed 4 years ago

willflet commented 4 years ago

This fixes a problem whereby each spanning cell in | spancell1 || spancell2 || cell | spancell3 || would get progressively larger instead of all spanning their intended number of cells.

Resolved by maintaining a count per cell as well as a row-wide count for removing trailing cells.

jeffreytse commented 4 years ago

Hi @willflet Thanks for your pr to fix the cell span issue. Since the function is designed to handle each cell, so in this function, the scope is current cell, I think scope.cell is redundant.