jeffreytse / jekyll-spaceship

🚀 A Jekyll plugin to provide powerful supports for table, mathjax, plantuml, mermaid, emoji, video, audio, youtube, vimeo, dailymotion, soundcloud, spotify, etc.
MIT License
605 stars 63 forks source link

Bug: When using {:target="_blank"} in the first link of the cell it is applied to <td>, not <a> as expexted #55

Closed rafaelspecta closed 3 years ago

rafaelspecta commented 3 years ago

Markdown

| Sample table | |
| --------------|----------------------------|
| Item 1        | [Google](https://google.com){:target="_blank"}  |
| ^^            | ^^ [Yahoo](https://yahoo.com){:target="_blank"}  |

Genarated HTML

<table>
  <thead>
    <tr>
      <th>Sample table</th>
      <th> </th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td rowspan="2">Item 1
        <br>
      </td>
      <td target="_blank" rowspan="2">
        <a href="https://google.com">Google</a>
        <br>
        <a href="https://yahoo.com" target="_blank">Yahoo</a>
      </td>
    </tr>
    <tr>
    </tr>
  </tbody>
</table>

Check this in the code:

<td target="_blank" rowspan="2">

If I remove {:target="_blank"} from the first link the target="_blank" disappears from <td>

table
rafaelspecta commented 3 years ago

Forgot to mention that I am using the latest version directly from git

jeffreytse commented 3 years ago

Hi @rafaelspecta

Thanks for the reporting, I will try to settle down this issue as soon as possible. And welcome to star this project for further updates in the future.

Thanks and regards

rafaelspecta commented 3 years ago

Thanks @jeffreytse . Let me know if you need any help.

jeffreytse commented 3 years ago

Hi @rafaelspecta

Thanks for your patience. This issue has been addressed and settled down, please update your plugin to the latest version.

Thanks and regards

jeffreytse commented 3 years ago

Hi @rafaelspecta

Has this issue been settled down? If you have any questions, please don't hesitate to tell me.

Thanks and regards

rafaelspecta commented 3 years ago

@jeffreytse seems to be working perfectly. Awesome, thanks.