search

jeffreytse / jekyll-theme-yat

🎨 Yet another theme for elegant writers with modern flat style and beautiful night/dark mode.
https://jeffreytse.github.io/jekyll-theme-yat
MIT License
978 stars 893 forks source link

Feature Request: Dark code blocks #24

Open illusion0001 opened 3 years ago

illusion0001 commented 3 years ago

As title suggested, currently when viewing code blocks in dark mode, the background and text remain in light theme.

https://jeffreytse.github.io/jekyll-theme-yat/markdown/2018/12/05/an-exhibit-of-markdown.html#h-code-block

jeffreytse commented 3 years ago

Hi @illusion0001

I will take a consideration for this feature request, welcome to star this repository for the updates in the near future.

Thanks and regards

illusion0001 commented 3 years ago

https://github.com/illusion0001/illusion0001.github.io/commit/8d209cb

I changed the hardcoded colors instead. perhaps there's a better way to do this?

image

jeffreytse commented 3 years ago

Hi @illusion0001

Yes, there is a better way by taking a dark theme for the code block. Now there are several open source works need to be maintained. Thanks for supporting my open source work! I will try to do this feature as soon as possible.

Thanks and regards