yet another starship vi mode indicator exception

A7R7 commented 1 year ago

General information

Terminal program: kitty, neovim terminal
Operating system: Archlinux
ZSH framework: zinit
ZSH version: 5.9 (x86_64-pc-linux-gnu)

Basic examination

[x] I have read through the README page
[x] I have the latest version of zsh-vi-mode
[x] I have tested with another terminal program

Problem description

Hi! Thank you for creating this amazing plugin!

Currently it works fine except that the starship vi mode do not work the default way. ('>' for insert mode and '<' for normal mode). And I do not set the character module in starship.toml, the starship config file, so it should work the default way.

I've checked issues raised by others (#126 #75) but it seems that they are actually complaining about their starship working normally. Therefore I guess you've "fixed" their issue by turning down starship's vi mode indicator feature by default.

I read through the readme and noticed that you can utilize ZVM_MODE to customize vi mode behavior. But forgive me that I'm not smart enough to write bash functions to control starship's behavior.

I really need starship's vi indicator feature because in neovim's terminal emulator the cursor width do not change even if you set it. This is a bug neovim have not fixed yet. ( for maybe 8 years! )

This is more of a question than an issue, your advice is highly appreciated!

Reproduction steps

install starship without modifying starship.toml
install zsh-vi-mode
press esc to enter normal mode and '>' do not change to '<'

Expected behavior

Starship's vi mode indicator should work normally. ('>' for insert mode and '<' for normal mode)

VeryDampTowel commented 1 year ago

I'm also experiencing this issue. ZSH 5.8 Terminal: Kitty Starship 1.15

It looks like a recent commit broke this functionality. Commit 8cb9a68925f1ec575e5f2384ec631942b089d87c is the most recent working version though so something in 5979662a11e139a3a87872d1a5282c836e98e608 messed things up.

You can switch to the working version with git checkout -b new_branch 8cb9a68. I'll see if I can pinpoint the specific part that messed things up later on.

jeffreytse commented 1 year ago

Hi @A7R7 @parispjones

This issue has been fixed, please see #219.

Thanks & Regards

jeffreytse commented 9 months ago

Hi @A7R7

If this issue has been settled down? Any problem, please let me know.

Thanks & Regards

jeffreytse / zsh-vi-mode