Strange behavior when hitting escape after hitting [cdy] - Githubissues

jeffreytse / zsh-vi-mode

💻 A better and friendly vi(vim) mode plugin for ZSH.

MIT License

3.25k stars 111 forks source link

Strange behavior when hitting escape after hitting [cdy] #295

Open Goose97 opened 2 weeks ago

Goose97 commented 2 weeks ago

General information

Terminal program: unknown unknown (xterm-kitty)
Operating system: macOS 15.0 (24A335)
ZSH framework:
ZSH version: zsh 5.9 (arm64-apple-darwin24.0)
ZVM version: zsh-vi-mode 0.11.0 (cd730cd, 2024-07-02 18:19:13 +0800)

Basic examination

[x] I have read through the README page
[x] I have the latest version of zsh-vi-mode
[ ] I have tested with another terminal program

Problem description

When I perform these key sequence in normal mode:

Hit either c, d or y
Hit Escape

Instead of exiting to normal mode, it enters visual mode.

https://github.com/user-attachments/assets/018ae762-55a8-4fe4-9614-d7b13fb28ea7

Reproduction steps

Make sure you are in normal mode
Hit c (or d, y)
Hit Escape

Expected behavior

Shell should exit to normal mode

Goose97 commented 2 weeks ago

After some git bisect, I believe 11ab44dc207ec8ebdcddd5ab7d77001d83032b54 is the commit that introduced this behavior.

I've tried to tweak it a little bit. Changing these lines fixes the issue. Not sure if it's the correct way to do it.

if [[ $(zvm_escape_non_printed_characters "$keys") =~
  ${ZVM_VI_OPPEND_ESCAPE_BINDKEY/\^\[/\\^\\[} ]]; then
-  return 1
+  return 0 # return 3 works as well
fi