search

jeffrifwald / babel-istanbul

Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.
Other
144 stars 23 forks source link

Collector should ignore everything that has line == 0 #14

Closed Swatinem closed 9 years ago

Swatinem commented 9 years ago

This is kind of like a workaround for #13

Not really sure if you want to move forward with this or not though.

tikotzky commented 9 years ago

:+1: this makes my coverage look much better :smile:

jeffrifwald commented 9 years ago

Looks good, just have a few questions:

Does this throw off coverage percentages? I'm not familiar enough with the reporting to tell immediately.

Second, do the skipped counts get filtered for the report? I would ideally like to hide the number of skips caused by babel-istanbul so people can keep track of how much they actually skip.

Swatinem commented 9 years ago

Yes, both. There are less statements (of which 100% are covered because they are ignored) so your coverage will be less. And since they are all removed, you won’t have any statements marked as ignored any more.