search

jeffrifwald / es6-fiddle-web

Fiddlin' with ECMAScript6.
https://es6fiddle.net
MIT License
49 stars 77 forks source link

Embed ES6fiddle feature #3

Closed jaydson closed 10 years ago

jaydson commented 10 years ago

Feature: Embedding iframes with saved es6 fiddles. Now, the saved fiddle page have a input with the iframe code for embedding. Issue #2.

jeffrifwald commented 10 years ago

@jaydson Thanks for looking into this. I will pull this code down and play with it.

You are failing some lint tests.

jeffrifwald commented 10 years ago

I would like that embed button to open a dropdown that contains the link.

I also think the embedded site needs to have a completely different format that just tabs between the code and the result. There would then be a link to 'edit in es6fiddle'. You could still used the same interface, just different css rules in the case of an embedded fiddle.

jaydson commented 10 years ago

Hey Jeff, I've pushed again with some fixes and we're not failing lint tests anymore.

About the dropdown feature and the different embedded format, can we plan this for the next release?

jeffrifwald commented 10 years ago

@jaydson I am going to go ahead and merge this. I will add dropdown and then deploy.

jaydson commented 10 years ago

Awesome.