search

jeffschubert / homebridge-daikin-oneplus

Homebridge plugin to control a Daikin One+ thermostat
Apache License 2.0
18 stars 7 forks source link

Duplicate Serial Numbers for All Accessories #23

Closed prsng closed 1 year ago

prsng commented 2 years ago

This issue does not point to any existing problem. I love the fact that I now have the thermostat and other accessories in HomeKit.

I downloaded Controller for Homekit app to validate issues, and the app, as a best practice recommends that Homebridge accessories (all exposed from this plugin) have duplicate serial numbers.

No alternatives are required thus far as everything works pretty well currently but I thought I would raise this so that you could look at this.

IMG_3C22CF3CD81D-1

jeffschubert commented 2 years ago

Thanks, I read up on this last year and I attempted to have unique serials starting off with the initial thermostat accessory. But as I exposed the fan/sensors/etc as separate accessories, I didn't realize they were all using the same uuid/serial. The biggest hurdle at this point is how to avoid changing the serial for existing accessories but make new accessories with unique serials. While HomeKit allows duplicate serials, it does require serial numbers to never change once the accessory is added.