search

jeffschubert / homebridge-daikin-oneplus

Homebridge plugin to control a Daikin One+ thermostat
Apache License 2.0
20 stars 7 forks source link

Enabled schedule may override changes set by HomeKit #3

Closed jeffschubert closed 3 years ago

jeffschubert commented 3 years ago

Jeff,

The update did fix the not responding issue perfectly, thank you! However, it brought to light another apparent issue. If the thermostat is set to a schedule it over-rides/prevents any changes made in HomeKit. 

Thanks

   Eric

On Jul 28, 2021, at 1:04 AM, jeffschubert @.***> wrote:

@EricTSten https://github.com/EricTSten I just published 1.0.3 which should fix the 'No Response' you're seeing. I still need to fix it temporarily showing the old value after you change it. It'll update to the new value for good once it refreshes values via the Daikin API.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jeffschubert/homebridge-daikin-oneplus/issues/1#issuecomment-888012717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU5X353CZUHHA43KVL2ZWL3TZ6FXNANCNFSM5AYZKSKQ.

Originally posted by @EricTSten in https://github.com/jeffschubert/homebridge-daikin-oneplus/issues/1#issuecomment-888251166

jeffschubert commented 3 years ago

@EricTSten, I created a separate issue to track this. I don't have a schedule set so I hadn't seen that. What happens if you change the temp directly on the thermostat? Does it change it or stick to the schedule? Or does it do a temporary hold of sorts at the custom temp until the next scheduled time?

I'll give it a try when I've got a free evening.

EricTSten commented 3 years ago

If I change the temp directly on the thermostat it goes into adjust mode and stays in that mode for an hour (setting on the thermostat for the length of time). When the thermostat is in adjust mode I am able to change the temp without issue from HomeKit via Homebridge.

jeffschubert commented 3 years ago

Thanks, I'll see what I can figure out. I'm betting that the thermostat ignores the normal set point variable when in a schedule and I need to find the appropriate temporary hold equivalent variable to set when the plugin detects a schedule is active.

jeffschubert commented 3 years ago

I think I've got a fix for this. Still need to test it locally. The Daikin app lets you set a couple things like a schedule override lasts for 1, 2, 4, 8 hours or until the next schedule time. My change will just override for an hour. I'll need to figure out how to override and honor whatever is already configured.

jeffschubert commented 3 years ago

@EricTSten v1.0.4 just published should fix this. Adjusting the temp from will pause the schedule and put the thermostat in adjust mode temporarily. In my testing it appears the schedule will remain paused based on your schedule settings.

EricTSten commented 3 years ago

Jeff,

I’m seeing that as well. Thanks for building the plugin and fixing this issue! 

Eric

On Aug 5, 2021, at 10:58 PM, jeffschubert @.***> wrote:

@EricTSten https://github.com/EricTSten v1.0.4 just published should fix this. Adjusting the temp from will pause the schedule and put the thermostat in adjust mode temporarily. In my testing it appears the schedule will remain paused based on your schedule settings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jeffschubert/homebridge-daikin-oneplus/issues/3#issuecomment-893964818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU5X352ON7S4K67UR5ZYYSLT3NFVTANCNFSM5BFJL6PQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.