search

jeffseo / ChampionMasteryPlanner

A tool for League of Legends users to plan out how many games are needed to obtain the champion points they want
1 stars 0 forks source link

Create Graphs for Champ Mastery by Day #19

Closed g5qinyix closed 8 years ago

g5qinyix commented 8 years ago

Create 2 graphs.

1) After user enters his summoner name, he'll be brought to the summoner.html page. We can include a graph that groups his last ten matches by day and calculates TOTAL NUMBER OF MASTERY POINTS FOR ALL CHAMPS. This graphs displays said value by day.

2) Similar to 1, but the graph is placed on the individual champion page. We look at last ten matches and see if the champion in question is in the matches and calculates point gain per day.

jeffseo commented 8 years ago

I think it would be sufficient for summoner page. Also, i don't think riots current api gives number of mastery points gained per match - I checked this /api/lol/{region}/v1.3/game/by-summoner/{summonerId}/recent. What we do have is the total champion score the summoner has from /championmastery/location/{platformId}/player/{playerId}/score

g5qinyix commented 8 years ago

Oh I somehow just saw your comment now.

Yeah I can see why adding a graph for champion is a little bit too much. We only have access to the 10 most recent games for a summoner. The chances that one champion will appear multiple times for that user is unlikely (some people spam one champ, but most just don't?). So it'll be common to see champion graphs with just one point of data.

g5qinyix commented 8 years ago

Closed as pull request accepted. #25