search

jeffsf / pyDE1

Controller for the Decent Espresso DE1
GNU General Public License v3.0
77 stars 16 forks source link

Return values of start/stop notifying aren't actionable #28

Closed jeffsf closed 2 years ago

jeffsf commented 2 years ago

start_notifying(cuuid) and stop_notifying(cuuid) appear to try to return a "success value".

As noted by Ray, the current return values don't reflect anything useful.

jeffsf commented 2 years ago

start_notifying() returns an asyncio.Event that is set when a notification on the CUUID is received

stop_notifying() previously returned None. It now does not return a value.

jeffsf commented 2 years ago

The start_notifying() returned and continues to return an event that will trigger when the notification is received.

stop_notifying() was returning None and no longer has a return value.