search

jeffshaver / safe-framework

MIT License
6 stars 1 forks source link

Closes #30 Closes #32 upgrade react-leaflet #36

Closed jpkeyw closed 8 years ago

jpkeyw commented 8 years ago

Map with Layers works correctly.

upgrade react-leaflet to 0.11.2 to fix LayersControl bug

jeffshaver commented 8 years ago

Why change Map to LayerMap?

jpkeyw commented 8 years ago

There's a DefaultMap and was a Map. Before I made the changes, Kris had copied the example which required like 4 separate files in addition to those. It was a jumble of spaghetti. In order to straighten things out, I made my component LayerMap. Besides, the whole point of using map is so you can add one or more layers of markers to it.

jeffshaver commented 8 years ago

Yeah. I think there's an assumption made here that no map would be useful as a visualization without adding layers to it. I think changing it back to Map would be fine