jeffshee / gnome-ext-hanabi

Live Wallpaper for GNOME
GNU General Public License v3.0
788 stars 24 forks source link

Using a short video will cause memory leaks #142

Open CristianoBarone opened 1 month ago

CristianoBarone commented 1 month ago

Description When using a video, once it loops it will be (or at least, I assume this is what happens) reallocated without freeing it first. This causes a problem when using a short HD video that ends taking up all the system memory in a few seconds.

OS and Shell Information Please provide your OS name and version, GNOME Shell version, and the session type (X11/Wayland).

Steps to Reproduce Please provide the steps to reproduce the bug you are encountering.

  1. Set a short video as wallpaper.
  2. Wait a few seconds.
  3. Experience massive memory leaks.

Expected Behavior The video is looped without allocating it again, or by freeing it and reallocating (although I really don't get why one would do this).

Actual Behavior Once the video loops it is (presumably) reallocated without freeing it, causing a massive memory leak.

Additional Information This happens both with VA on or off. Both with and without gtk4paintablesink and/or GtkMediaFile.

h3sam commented 1 month ago

I also experienced this when trying to loop a short (2 second long) video with this extension.