search

jeffsieu / pe

0 stars 0 forks source link

Settings and help theme not in dark despite the chosen theme being dark #3

Open jeffsieu opened 3 years ago

jeffsieu commented 3 years ago

Issue

The theme choice is not consistent throughout the app.

Steps to reproduce

  1. Launch the app from scratch.
  2. Open the Settings menu under File > Settings.
  3. Observe that the current theme is set to "DARK"
  4. The settings window itself is not in dark theme. The help window launched from executing help is also not in dark theme.

Expected behaviour

Everything to be in dark theme.

Actual behaviour

The settings and help windows are in light theme when the chosen theme is "DARK".

Screenshots

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for your suggestion. We will take that into consideration 😊.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The help window is part of the application, so I don't see a reason why this should be not in scope.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: This is not a flaw with the theme toggle, but rather that the toggle gives unexpected behaviour (user expected everything to be themed). This fits the behaviour "differs from normal expectations" definition of functionality bug.

image.png

image.png